From e854088f20e02d494381a40fce20654526577792 Mon Sep 17 00:00:00 2001 From: TheScarastic Date: Thu, 14 Oct 2021 01:19:10 +0530 Subject: [PATCH] doze: Adapt to S style * Reference https://github.com/TheScarastic/android_device_xiaomi_raphael/commit/e7db7fc560787440784b6c9787da2e1ab2695f59 * Adapted and rewritten in Kt * Use Theme.SubSettingsBase for theme * Replace PreferenceActivity with CollapsingToolbarBaseActivity * Add Titles to preference screen * Remove onOptionsItemSelected and where neccessary move to activity Change-Id: I4d35ade6f45022944df4db787948c03b5bc14e5f Signed-off-by: Rohan Hasabe Signed-off-by: Bruno Martins --- doze/AndroidManifest.xml | 2 +- doze/proguard.flags | 2 +- doze/res/color/switch_bar_bg.xml | 20 ------ doze/res/drawable/switchbar_background.xml | 20 ------ doze/res/layout/doze.xml | 27 ------- doze/res/layout/switch_bar.xml | 49 ------------- doze/res/values-night/colors.xml | 20 ------ doze/res/values/colors.xml | 21 ------ doze/res/values/styles.xml | 72 ------------------- doze/res/xml/doze_settings.xml | 16 ++++- .../settings/doze/DozeSettingsActivity.kt | 7 +- .../settings/doze/DozeSettingsFragment.kt | 63 +++------------- doze/src/org/lineageos/settings/doze/Utils.kt | 1 + 13 files changed, 32 insertions(+), 288 deletions(-) delete mode 100644 doze/res/color/switch_bar_bg.xml delete mode 100644 doze/res/drawable/switchbar_background.xml delete mode 100644 doze/res/layout/doze.xml delete mode 100644 doze/res/layout/switch_bar.xml delete mode 100644 doze/res/values-night/colors.xml delete mode 100644 doze/res/values/colors.xml delete mode 100644 doze/res/values/styles.xml diff --git a/doze/AndroidManifest.xml b/doze/AndroidManifest.xml index 388081a..64787d7 100644 --- a/doze/AndroidManifest.xml +++ b/doze/AndroidManifest.xml @@ -47,7 +47,7 @@ android:name=".DozeSettingsActivity" android:exported="false" android:label="@string/ambient_display_title" - android:theme="@style/Theme.Main"> + android:theme="@style/Theme.SubSettingsBase"> diff --git a/doze/proguard.flags b/doze/proguard.flags index b1cabdb..eb350a0 100644 --- a/doze/proguard.flags +++ b/doze/proguard.flags @@ -2,7 +2,7 @@ public (android.content.Context, android.util.AttributeSet); } --keep class ** extends android.support.v14.preference.PreferenceFragment +-keep class ** extends androidx.preference.PreferenceFragment -keep class org.lineageos.settings.doze.* { *; } diff --git a/doze/res/color/switch_bar_bg.xml b/doze/res/color/switch_bar_bg.xml deleted file mode 100644 index ca13e3c..0000000 --- a/doze/res/color/switch_bar_bg.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - - diff --git a/doze/res/drawable/switchbar_background.xml b/doze/res/drawable/switchbar_background.xml deleted file mode 100644 index f210707..0000000 --- a/doze/res/drawable/switchbar_background.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - diff --git a/doze/res/layout/doze.xml b/doze/res/layout/doze.xml deleted file mode 100644 index a7ce3e0..0000000 --- a/doze/res/layout/doze.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - - - diff --git a/doze/res/layout/switch_bar.xml b/doze/res/layout/switch_bar.xml deleted file mode 100644 index 1bf6f6c..0000000 --- a/doze/res/layout/switch_bar.xml +++ /dev/null @@ -1,49 +0,0 @@ - - - - - - - - - - diff --git a/doze/res/values-night/colors.xml b/doze/res/values-night/colors.xml deleted file mode 100644 index 5aa9c8e..0000000 --- a/doze/res/values-night/colors.xml +++ /dev/null @@ -1,20 +0,0 @@ - - - - - #82000000 - @android:color/black - diff --git a/doze/res/values/colors.xml b/doze/res/values/colors.xml deleted file mode 100644 index bb85f62..0000000 --- a/doze/res/values/colors.xml +++ /dev/null @@ -1,21 +0,0 @@ - - - - - @*android:color/material_grey_600 - #BFFFFFFF - @android:color/white - diff --git a/doze/res/values/styles.xml b/doze/res/values/styles.xml deleted file mode 100644 index d74e7c0..0000000 --- a/doze/res/values/styles.xml +++ /dev/null @@ -1,72 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - diff --git a/doze/res/xml/doze_settings.xml b/doze/res/xml/doze_settings.xml index f8cba2b..faa6d8c 100644 --- a/doze/res/xml/doze_settings.xml +++ b/doze/res/xml/doze_settings.xml @@ -1,7 +1,7 @@ - + + + + + (android.R.id.switch_widget) - switchWidget.isChecked = dozeEnabled - switchWidget.setOnCheckedChangeListener(this) - - switchBar.isActivated = dozeEnabled - switchBar.setOnClickListener { - switchWidget.isChecked = !switchWidget.isChecked - switchBar.isActivated = switchWidget.isChecked - } - } - override fun onPreferenceChange(preference: Preference, newValue: Any?): Boolean { if (preference.key == Utils.ALWAYS_ON_DISPLAY) { Utils.enableAlwaysOn(context, newValue as Boolean) @@ -117,13 +87,11 @@ class DozeSettingsFragment : PreferenceFragment(), Preference.OnPreferenceChange return true } - override fun onCheckedChanged(compoundButton: CompoundButton, isChecked: Boolean) { + override fun onSwitchChanged(switchView: Switch, isChecked: Boolean) { Utils.enableDoze(context, isChecked) Utils.checkDozeService(context) - textView.text = - getString(if (isChecked) R.string.switch_bar_on else R.string.switch_bar_off) - switchBar.isActivated = isChecked + switchBar.isChecked = isChecked if (!isChecked) { Utils.enableAlwaysOn(context, false) @@ -135,13 +103,4 @@ class DozeSettingsFragment : PreferenceFragment(), Preference.OnPreferenceChange pocketPreference?.isEnabled = isChecked } - override fun onOptionsItemSelected(item: MenuItem): Boolean { - return when (item.itemId) { - R.id.home -> { - activity.onBackPressed() - true - } - else -> false - } - } } diff --git a/doze/src/org/lineageos/settings/doze/Utils.kt b/doze/src/org/lineageos/settings/doze/Utils.kt index c47891d..8dbbde9 100644 --- a/doze/src/org/lineageos/settings/doze/Utils.kt +++ b/doze/src/org/lineageos/settings/doze/Utils.kt @@ -23,6 +23,7 @@ object Utils { private const val DOZE_INTENT = "com.android.systemui.doze.pulse" const val ALWAYS_ON_DISPLAY = "always_on_display" + const val DOZE_ENABLE = "doze_enable" const val CATEGORY_PICKUP_SENSOR = "pickup_sensor" const val CATEGORY_PROXIMITY_SENSOR = "proximity_sensor"