psmattas/android_system_qcom-lineage
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qsap: Add NULL check for soc & msg allocations in qsap_get_mode

Browse Source 
Add appropriate checks to avoid NULL pointer dereferencing.

Change-Id: I9b96eeb1cf3b860416c950b5c689dc5858e194c6
CRs-Fixed: 2300013
This commit is contained in:
Srikanth Marepalli
2018-08-23 19:15:57 +05:30
committed by Gerrit - the friendly Code Review server
parent 68e72488ab
commit 71d1ddbe77
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
softap/sdk/qsap_api.c
View File

@@ -1349,6 +1349,12 @@ int qsap_get_mode(s32 *pmode)
//allocate socket //allocate socket
sk = nl_socket_alloc(); sk = nl_socket_alloc();
//return if socket allocation fails
if(sk == NULL){
ALOGE( "socket allocation failure");
return ret;
}
//connect to generic netlink //connect to generic netlink
if (genl_connect(sk)) { if (genl_connect(sk)) {
ALOGE( "Netlink socket Connection failure"); ALOGE( "Netlink socket Connection failure");
@@ -1366,6 +1372,12 @@ int qsap_get_mode(s32 *pmode)
//allocate a message //allocate a message
msg = nlmsg_alloc(); msg = nlmsg_alloc();
//return if message allocation fails
if(msg == NULL){
ALOGE( "message allocation failure");
goto nla_put_failure;
}
// setup the message // setup the message
genlmsg_put(msg, 0, 0, nl80211_id, 0, 0, NL80211_CMD_GET_INTERFACE, 0); genlmsg_put(msg, 0, 0, nl80211_id, 0, 0, NL80211_CMD_GET_INTERFACE, 0);