Contains updates by Griffin Millender <griffinn.millender@gmail.com> and
the SlimROMs team
AICPfy:
- make it play better with themes
- bring it to Oreo
- Update SettingsActivity to forward extras from PreferenceScreen to the new fragment
(allows using DSLV from xml)
Change-Id: I7514cdfa3603ed6e24deeb251875a716a52a02b1
Up til now this has been gone unnoticed. Without a text limit the user
could very easily blow up the statusbar to the point that is not usable.
Change-Id: I2813af9e12c6d29e020669e0626faec8422fedbe
When checking for isChecked in e.g. a preferenceFragment, we want to
know the setting value, independent of whether the preference already
has been inflated or not
Change-Id: Ie3e777388805d329fea6f56ef306a4c941993938
Signed-off-by: spezi77 <spezi7713@gmx.net>
- Import MasterSwitchPreference from Settings(Lib)
- Add System setting variant + fix initial values
- Use icon_frame as ic in layout instead of icon_container to fix hiding
icon
- Allow launching fragments with the android:fragment extra same as
currently possible for PreferenceScreens
- Add possibility to reload value when it might have changed
(best to call onResume when the value can also be changed from the
sub preference screen)
@ZeNiXxX: Adapt to AndroidX
Original commit history for TwoTargetPreference from
frameworks/base/packages/SettingsLib:
commit 8a01abf592762c75bb92a9e1787227c44f1f4a8e
Author: Fan Zhang <zhfan@google.com>
Adjust icon width to match the width with framework
commit 035ff93430b71ef856f299c9f676f8d340403e16
Author: Fan Zhang <zhfan@google.com>
Move two target preference layout from settings to lib
Original commit history for MasterSwitchPreference.java:
commit e2ad415fdba79b27dfd2c98a2b01d56db9257c71
Author: Doris Ling <dling@google.com>
Add content description to the master switch toggle button.
commit c68ae0b9fdd5f5a149364d0af7e8a9497a91adfd
Author: Julia Reynolds <juliacr@google.com>
Channel settings updates
commit aa805e70ed0c7f4eaa66b6e6a0b79bf1b3b9d16d
Author: Doris Ling <dling@google.com>
Allow settings preference title to span over multiple lines.
commit fe292515d88e803057a5b6077f67ce284b595d7a
Author: Fan Zhang <zhfan@google.com>
Refactor the layout for MasterSwitch to a 2 target pref
commit 6467d2027e8fefd646af03c08d51d91386843463
Author: Doris Ling <dling@google.com>
Extends the touch area for the switch in Master Switch preference.
commit 762a733afa26b3d49edfae81536c9fcbe9384483
Author: Julia Reynolds <juliacr@google.com>
Allow switch preferences to span lines.
commit 56199e94876d4bbd89fb0272156702a321dd681e
Author: Fan Zhang <zhfan@google.com>
Misc fix on network & internet screen for developer preview
commit c4c9f4d50eec659eb50f8ed671c27d8c6ef0c924
Author: Doris Ling <dling@google.com>
Update Network & internet->Wi-Fi to use MasterSwitchPreference.
commit 1432cb852972daedd6c2fde78abb769b722fc47d
Author: Doris Ling <dling@google.com>
Add new preference class MasterSwitchPreference.
Original commit history for preference_widget_master_switch.xml:
commit fe292515d88e803057a5b6077f67ce284b595d7a
Author: Fan Zhang <zhfan@google.com>
Refactor the layout for MasterSwitch to a 2 target pref
commit 6467d2027e8fefd646af03c08d51d91386843463
Author: Doris Ling <dling@google.com>
Extends the touch area for the switch in Master Switch preference.
commit 14c2050330b36a00b708049a691d4e1c39700586
Merge: 249077a0cd 56199e9487
Author: TreeHugger Robot <treehugger-gerrit@google.com>
Merge "Misc fix on network & internet screen for developer preview"
commit 56199e94876d4bbd89fb0272156702a321dd681e
Author: Fan Zhang <zhfan@google.com>
Misc fix on network & internet screen for developer preview
commit 4f1eca05be15b9a30757434ce6c11abe5e6db381
Author: Doris Ling <dling@google.com>
Update the color for the master switch divider.
commit 1432cb852972daedd6c2fde78abb769b722fc47d
Author: Doris Ling <dling@google.com>
Add new preference class MasterSwitchPreference.
Change-Id: I7ee76f4626223ec3c66ae7d10ebb87c88c5a8175
Signed-off-by: spezi77 <spezi7713@gmx.net>
08-23 20:07:44.650 31111 31111 E AndroidRuntime: Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void android.widget.TextView.setText(java.lang.CharSequence)' on a null object reference
08-23 20:07:44.650 31111 31111 E AndroidRuntime: at com.nitrogen.settings.preferences.CustomSeekBarPreference.setDefaultValue(CustomSeekBarPreference.java:240)
when CustomSeekBar is called, it does:
mSeekBar.setMax(mMax - mMin);
assuming mMin=0 and mMax=100 if they are not set with settings:min or max
through the related menu xml.
So if we set one of those values in the related menu java class with the
available public voids (setMax(value) and setMin(value)) the seekbar doesn't
get the new min and max thus the user can't slide it to the max position.
To reply:
- set settings:max (or android:max according to your customseekbar implementation)
to the wanted value, e.g. 255;
- set the min value through your menu java class with CustomSeekBarPreference.setMin(value);
- try to move the progressbar thumb to the max position, it won't reach it.
Signed-off-by: xyyx <xyyx@mail.ru>