From 175ef484d5382de16bcdd32f952d0754f2e7df8c Mon Sep 17 00:00:00 2001 From: jhonboy121 Date: Tue, 4 Oct 2022 18:14:44 +0530 Subject: [PATCH] Cherish: applock: early return in setChecked if backing field has the same value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: jhonboy121 Signed-off-by: Hưng Phan --- .../security/applock/AppLockBiometricPreferenceController.kt | 1 + .../settings/security/applock/AppLockNotificationRedactionPC.kt | 1 + .../settings/security/applock/AppLockPackageProtectionPC.kt | 1 + 3 files changed, 3 insertions(+) diff --git a/src/com/cherish/settings/security/applock/AppLockBiometricPreferenceController.kt b/src/com/cherish/settings/security/applock/AppLockBiometricPreferenceController.kt index cf90a9e..2172a4f 100644 --- a/src/com/cherish/settings/security/applock/AppLockBiometricPreferenceController.kt +++ b/src/com/cherish/settings/security/applock/AppLockBiometricPreferenceController.kt @@ -63,6 +63,7 @@ class AppLockBiometricPreferenceController( override fun isChecked() = isBiometricsAllowed override fun setChecked(checked: Boolean): Boolean { + if (isBiometricsAllowed == checked) return false isBiometricsAllowed = checked coroutineScope.launch(Dispatchers.Default) { appLockManager.setBiometricsAllowed(isBiometricsAllowed) diff --git a/src/com/cherish/settings/security/applock/AppLockNotificationRedactionPC.kt b/src/com/cherish/settings/security/applock/AppLockNotificationRedactionPC.kt index a63302a..3dcfd5a 100644 --- a/src/com/cherish/settings/security/applock/AppLockNotificationRedactionPC.kt +++ b/src/com/cherish/settings/security/applock/AppLockNotificationRedactionPC.kt @@ -59,6 +59,7 @@ class AppLockNotificationRedactionPC( override fun isChecked() = shouldRedactNotification override fun setChecked(checked: Boolean): Boolean { + if (shouldRedactNotification == checked) return false shouldRedactNotification = checked coroutineScope.launch(Dispatchers.Default) { appLockManager.setShouldRedactNotification(packageName, checked) diff --git a/src/com/cherish/settings/security/applock/AppLockPackageProtectionPC.kt b/src/com/cherish/settings/security/applock/AppLockPackageProtectionPC.kt index 519b714..05c8e1a 100644 --- a/src/com/cherish/settings/security/applock/AppLockPackageProtectionPC.kt +++ b/src/com/cherish/settings/security/applock/AppLockPackageProtectionPC.kt @@ -60,6 +60,7 @@ class AppLockPackageProtectionPC( override fun isChecked() = isProtected override fun setChecked(checked: Boolean): Boolean { + if (isProtected == checked) return false isProtected = checked coroutineScope.launch(Dispatchers.Default) { if (isProtected) {