Puranjay Savar Mattas
6e1ffb96fd
Convert from git submodule to plain vendored copy. No push access to upstream nodes-app/swift-markdown-engine meant our local fix commit (05c1720) was stranded and unreachable from any remote on fresh clones/CI. Vendoring as plain files folds it into normal repo history instead.
104 lines
3.7 KiB
Swift
104 lines
3.7 KiB
Swift
//
|
|
// ScrollMemoryTests.swift
|
|
// MarkdownEngineTests
|
|
//
|
|
// Created by Luca Chen on 06.08.26.
|
|
//
|
|
// The embedder-owned scroll memory: the teardown hand-off and the restore
|
|
// latch. The restore itself runs inside `updateNSView`, which needs a SwiftUI
|
|
// `Context` that cannot be built headlessly — verify that in a host app.
|
|
//
|
|
|
|
import AppKit
|
|
import SwiftUI
|
|
import Testing
|
|
@testable import MarkdownEngine
|
|
|
|
@MainActor
|
|
private func makeCoordinator(documentId: String?) -> NativeTextViewCoordinator {
|
|
var text = ""
|
|
var wikiActive = false
|
|
let coordinator = NativeTextViewCoordinator(
|
|
text: Binding(get: { text }, set: { text = $0 }),
|
|
fontName: "SF Pro",
|
|
fontSize: 16,
|
|
isWikiLinkActive: Binding(get: { wikiActive }, set: { wikiActive = $0 }),
|
|
onLinkClick: nil,
|
|
onInlineSelectionChange: nil
|
|
)
|
|
coordinator.documentId = documentId
|
|
return coordinator
|
|
}
|
|
|
|
@MainActor
|
|
private func makeScrollView(scrolledTo offsetY: CGFloat) -> NSScrollView {
|
|
let scrollView = ClampedScrollView(frame: NSRect(x: 0, y: 0, width: 600, height: 400))
|
|
let documentView = NSView(frame: NSRect(x: 0, y: 0, width: 600, height: 4000))
|
|
scrollView.documentView = documentView
|
|
scrollView.contentView.scroll(to: NSPoint(x: 0, y: offsetY))
|
|
scrollView.reflectScrolledClipView(scrollView.contentView)
|
|
return scrollView
|
|
}
|
|
|
|
@Suite("Embedder scroll memory")
|
|
@MainActor
|
|
struct ScrollMemoryTests {
|
|
|
|
@Test("Teardown hands the current offset to the embedder")
|
|
func dismantlePersistsOffset() {
|
|
var persisted: [String: CGFloat] = [:]
|
|
let coordinator = makeCoordinator(documentId: "note-a")
|
|
coordinator.onPersistScrollOffset = { persisted[$0] = $1 }
|
|
let scrollView = makeScrollView(scrolledTo: 1234)
|
|
|
|
NativeTextViewWrapper.dismantleNSView(scrollView, coordinator: coordinator)
|
|
|
|
#expect(persisted == ["note-a": 1234])
|
|
}
|
|
|
|
@Test("Teardown without a current document persists nothing")
|
|
func dismantleWithoutDocumentIdPersistsNothing() {
|
|
var callCount = 0
|
|
let coordinator = makeCoordinator(documentId: nil)
|
|
coordinator.onPersistScrollOffset = { _, _ in callCount += 1 }
|
|
|
|
NativeTextViewWrapper.dismantleNSView(makeScrollView(scrolledTo: 1234), coordinator: coordinator)
|
|
|
|
#expect(callCount == 0)
|
|
}
|
|
|
|
@Test("Teardown mid-restore keeps the remembered offset instead of the load position")
|
|
func dismantleDuringPendingRestorePersistsNothing() {
|
|
var callCount = 0
|
|
let coordinator = makeCoordinator(documentId: "note-a")
|
|
coordinator.onPersistScrollOffset = { _, _ in callCount += 1 }
|
|
coordinator.armScrollRestore(for: "note-a")
|
|
|
|
NativeTextViewWrapper.dismantleNSView(makeScrollView(scrolledTo: 0), coordinator: coordinator)
|
|
|
|
#expect(callCount == 0)
|
|
}
|
|
|
|
@Test("Arming latches the document and gives it a bounded retry budget")
|
|
func armingLatchesWithBudget() {
|
|
let coordinator = makeCoordinator(documentId: "note-a")
|
|
#expect(coordinator.pendingScrollRestoreDocumentId == nil)
|
|
|
|
coordinator.armScrollRestore(for: "note-a")
|
|
|
|
#expect(coordinator.pendingScrollRestoreDocumentId == "note-a")
|
|
#expect(coordinator.pendingScrollRestoreAttempts > 1)
|
|
}
|
|
|
|
@Test("Typing disarms a restore that has not landed yet")
|
|
func typingDisarmsPendingRestore() {
|
|
let coordinator = makeCoordinator(documentId: "note-a")
|
|
coordinator.armScrollRestore(for: "note-a")
|
|
let textView = NativeTextView(frame: .zero)
|
|
|
|
coordinator.textDidChange(Notification(name: NSText.didChangeNotification, object: textView))
|
|
|
|
#expect(coordinator.pendingScrollRestoreDocumentId == nil)
|
|
}
|
|
}
|